-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: even no endpoints left after filter, an empty object should be returned to clients #1028
bugfix: even no endpoints left after filter, an empty object should be returned to clients #1028
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zzguang @yingjianjian PTAL |
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 47.74% 47.94% +0.20%
==========================================
Files 95 95
Lines 13013 12970 -43
==========================================
+ Hits 6213 6219 +6
+ Misses 6266 6216 -50
- Partials 534 535 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1a9753f
to
2de271e
Compare
…e returned to clients
2de271e
to
16d281c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/backport release-v1.0 |
1 similar comment
/backport release-v1.0 |
Successfully created backport PR #1030 for |
What type of PR is this?
/kind bug
What this PR does / why we need it:
if no endpoints left after service topology filtering, yurthub should return a empty endpointslice to clients(like kube-proxy) instead of skipping the object. because kube-proxy need to use the empty endpointslice to update network setting on edge nodes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note