Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: even no endpoints left after filter, an empty object should be returned to clients #1028

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

if no endpoints left after service topology filtering, yurthub should return a empty endpointslice to clients(like kube-proxy) instead of skipping the object. because kube-proxy need to use the empty endpointslice to update network setting on edge nodes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

if no endpoints left after service topology filtering, yurthub should return a empty endpointslice to clients(like kube-proxy) instead of skipping the object. because kube-proxy need to use the empty endpointslice to update network setting on edge nodes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/L size/L: 100-499 labels Oct 11, 2022
@rambohe-ch
Copy link
Member Author

@zzguang @yingjianjian PTAL

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1028 (16d281c) into master (cd00f26) will increase coverage by 0.20%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
+ Coverage   47.74%   47.94%   +0.20%     
==========================================
  Files          95       95              
  Lines       13013    12970      -43     
==========================================
+ Hits         6213     6219       +6     
+ Misses       6266     6216      -50     
- Partials      534      535       +1     
Flag Coverage Δ
unittests 47.94% <66.66%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/filter/servicetopology/handler.go 74.75% <66.66%> (+15.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch rambohe-ch force-pushed the fix-service-topology branch from 1a9753f to 2de271e Compare October 12, 2022 09:08
@openyurt-bot openyurt-bot added size/XXL and removed size/L size/L: 100-499 labels Oct 12, 2022
@rambohe-ch rambohe-ch force-pushed the fix-service-topology branch from 2de271e to 16d281c Compare October 12, 2022 09:45
Copy link
Member

@Congrool Congrool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 14, 2022
@openyurt-bot openyurt-bot merged commit e7cb7d9 into openyurtio:master Oct 14, 2022
@rambohe-ch rambohe-ch added the backport release-v1.0 backport release-v1.0 label Oct 14, 2022
@rambohe-ch
Copy link
Member Author

/backport release-v1.0

1 similar comment
@rambohe-ch
Copy link
Member Author

/backport release-v1.0

@github-actions
Copy link

Successfully created backport PR #1030 for release-v1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.0 backport release-v1.0 kind/bug kind/bug lgtm lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants