Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python binding for stablehlo.register_passes #2401

Merged
merged 2 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -841,12 +841,14 @@ gentbl_cc_library(
STABLEHLO_CAPI_SOURCES = [
"stablehlo/integrations/c/StablehloAttributes.cpp",
"stablehlo/integrations/c/StablehloDialect.cpp",
"stablehlo/integrations/c/StablehloPasses.cpp",
"stablehlo/integrations/c/StablehloTypes.cpp",
]

STABLEHLO_CAPI_HEADERS = [
"stablehlo/integrations/c/StablehloAttributes.h",
"stablehlo/integrations/c/StablehloDialect.h",
"stablehlo/integrations/c/StablehloPasses.h",
"stablehlo/integrations/c/StablehloTypes.h",
]

Expand All @@ -857,6 +859,7 @@ cc_library(
strip_include_prefix = ".",
deps = [
":stablehlo_ops",
":stablehlo_passes",
"@llvm-project//mlir:CAPIIR",
],
)
Expand All @@ -879,6 +882,7 @@ cc_library(
strip_include_prefix = ".",
deps = [
":stablehlo_ops",
":stablehlo_passes",
"@llvm-project//mlir:CAPIIRObjects",
],
alwayslink = True,
Expand Down
2 changes: 2 additions & 0 deletions stablehlo/integrations/c/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ add_mlir_public_c_api_library(StablehloCAPI
PARTIAL_SOURCES_INTENDED
StablehloAttributes.cpp
StablehloDialect.cpp
StablehloPasses.cpp
StablehloTypes.cpp

LINK_LIBS PUBLIC
StablehloOps
StablehloPasses
)

add_mlir_public_c_api_library(VhloCAPI
Expand Down
17 changes: 17 additions & 0 deletions stablehlo/integrations/c/StablehloPasses.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* Copyright 2024 The StableHLO Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#include "stablehlo/integrations/c/StablehloPasses.h"

#include "stablehlo/transforms/Passes.h"

void mlirRegisterAllStablehloPasses() { mlir::stablehlo::registerPasses(); }
30 changes: 30 additions & 0 deletions stablehlo/integrations/c/StablehloPasses.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/* Copyright 2024 The StableHLO Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#ifndef STABLEHLO_INTEGRATIONS_C_STABLEHLO_PASSES_H
#define STABLEHLO_INTEGRATIONS_C_STABLEHLO_PASSES_H

#include "mlir-c/IR.h"
#include "mlir-c/Support.h"

#ifdef __cplusplus
extern "C" {
#endif

/// Register all compiler passes of StableHLO.
MLIR_CAPI_EXPORTED void mlirRegisterAllStablehloPasses();

#ifdef __cplusplus
}
#endif

#endif // STABLEHLO_INTEGRATIONS_C_STABLEHLO_PASSES_H
1 change: 1 addition & 0 deletions stablehlo/integrations/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ declare_mlir_python_extension(StablehloPythonExtensions.Main
EMBED_CAPI_LINK_LIBS
StablehloCAPI
PRIVATE_LINK_LIBS
StablehloPasses
StablehloPortableApi
StablehloReferenceApi
StablehloSerialization
Expand Down
8 changes: 8 additions & 0 deletions stablehlo/integrations/python/StablehloModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ limitations under the License.
#include "stablehlo/dialect/Serialization.h"
#include "stablehlo/integrations/c/StablehloAttributes.h"
#include "stablehlo/integrations/c/StablehloDialect.h"
#include "stablehlo/integrations/c/StablehloPasses.h"
#include "stablehlo/integrations/c/StablehloTypes.h"
#include "stablehlo/integrations/python/PortableApi.h"
#include "stablehlo/reference/Api.h"
Expand Down Expand Up @@ -65,6 +66,13 @@ PYBIND11_MODULE(_stablehlo, m) {
},
py::arg("context"), py::arg("load") = true);

//
// Passes.
//

m.def("register_stablehlo_passes",
[]() { mlirRegisterAllStablehloPasses(); });

//
// Types.
//
Expand Down
24 changes: 23 additions & 1 deletion stablehlo/integrations/python/tests/stablehlo.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@

# pylint: disable=wildcard-import,undefined-variable

import re
import io
import re
from mlir import ir
from mlir import passmanager as pm
from mlir.dialects import stablehlo
import numpy as np

Expand Down Expand Up @@ -304,6 +305,7 @@ def test_serialization_apis():
deserialized = stablehlo.deserialize_portable_artifact(context, serialized)
assert module_str == str(deserialized)


@run
def test_str_serialization_apis():
curr_version = stablehlo.get_current_version()
Expand All @@ -323,3 +325,23 @@ def module_to_bytecode(module: ir.Module) -> bytes:
deserialized = stablehlo.deserialize_portable_artifact(serialized)
deserialized_module = ir.Module.parse(deserialized)
assert module_str == str(deserialized_module)


@run
def test_register_passes():
"""Tests pass registration."""
with ir.Context() as context:
stablehlo.register_dialect(context)
module = ir.Module.parse(ASM_FORMAT.format("2xf32"))
assert module is not None

stablehlo.register_stablehlo_passes()
pipeline = [
"stablehlo-legalize-to-vhlo",
"vhlo-legalize-to-stablehlo",
]
pipeline = pm.PassManager.parse(f"builtin.module({','.join(pipeline)})")

cloned_module = module.operation.clone()
pipeline.run(cloned_module.operation)
assert str(module) == str(cloned_module)
Loading