Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of __PRETTY_FUNCTION__ with LLVM_PRETTY_FUNCTION #149

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

GleasonK
Copy link
Member

Use LLVM_PRETTY_FUNCTION instead of __PRETTY_FUNCTION__ since it is portable. IREE had reported build errors on windows using __PRETTY_FUNCTION__ for this reason.

Tested debug trace locally, and verified that all uses were changed with the following:

./openxla/stablehlo$ grep -rnw . -e ".*PRETTY.*"
./stablehlo/dialect/ChloBytecode.cpp:43:                      << _EXTRACT_AFTER(LLVM_PRETTY_FUNCTION, func) << '\n')
./stablehlo/dialect/ChloBytecode.cpp:50:                                       << LLVM_PRETTY_FUNCTION << '\n')
./stablehlo/dialect/StablehloBytecode.cpp:42:                      << _EXTRACT_AFTER(LLVM_PRETTY_FUNCTION, func) << '\n')
./stablehlo/dialect/StablehloBytecode.cpp:49:      llvm::errs() << "***Not Implemented: " << LLVM_PRETTY_FUNCTION << '\n')

Closes #147

@GleasonK GleasonK requested a review from burmako September 19, 2022 16:32
@GleasonK GleasonK merged commit f43b942 into openxla:main Sep 19, 2022
@GleasonK GleasonK deleted the pretty-funciton branch September 21, 2022 14:52
GleasonK added a commit to GleasonK/stablehlo that referenced this pull request Oct 24, 2022
…a#149)

Replace uses of __PRETTY_FUNCTION__ with LLVM_PRETTY_FUNCTION
GleasonK added a commit to GleasonK/stablehlo that referenced this pull request Nov 10, 2022
…a#149)

Replace uses of __PRETTY_FUNCTION__ with LLVM_PRETTY_FUNCTION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__PRETTY_FUNCTION__ is not portable
2 participants