Support qdq decomposition of TanOp (#2459)

[parent PR](#2458) The PR adds patterns for qdq decomposition patterns for newly added `TanOp` Note to the reviewers: To may just focus on the very last commit of the chain. The rest is coming from parent PR. [childPR](#2460)
openxla · Jul 26, 2024 · 4286b80 · 4286b80
1 parent 2980259
commit 4286b80
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/stablehlo/tests/stablehlo_legalize_quant_to_int.mlir b/stablehlo/tests/stablehlo_legalize_quant_to_int.mlir
@@ -2388,12 +2388,16 @@ func.func @send(%arg0: tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>, %token0: !s
 }
 
 // -----
+
+// CHECK-LABEL:  func.func @tan
 func.func @tan(%arg0: tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>) -> tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>> {
-  // expected-error@+1 {{failed to legalize operation 'stablehlo.tan' that was explicitly marked illegal}}
   %0 = "stablehlo.tan"(%arg0) : (tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>) -> tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>
   func.return %0 : tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>
 }
 
+// CHECK: stablehlo.tan {{.*}} : tensor<1x2x2xf32>
+
+
 // -----
 func.func @tuple(%arg0: tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>,
                  %arg1: tensor<1x2x2x!quant.uniform<i8:f32, 1.0:17>>) {

diff --git a/stablehlo/transforms/StablehloLegalizeQuantizedOpToQDQ.cpp b/stablehlo/transforms/StablehloLegalizeQuantizedOpToQDQ.cpp
@@ -124,7 +124,7 @@ void populateStablehloLegalizeQuantizedOpToQDQPatterns(
       CosineOp, DivOp, Expm1Op, ExpOp, FloorOp, Log1pOp, LogisticOp, LogOp,
       MaxOp, MinOp, MulOp, NegOp, PowOp, ReducePrecisionOp, RemOp, RoundOp,
       RoundNearestEvenOp, RsqrtOp, SelectOp, SignOp, SineOp, SqrtOp, SubtractOp,
-      TanhOp, TriangularSolveOp>(patterns, context, benefit);
+      TanhOp, TanOp, TriangularSolveOp>(patterns, context, benefit);
 }
 
 }  // namespace stablehlo