Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapcast: add snapserver and snapclient packages #23956

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

snapcast: add snapserver and snapclient packages #23956

wants to merge 3 commits into from

Conversation

xabolcs
Copy link
Contributor

@xabolcs xabolcs commented Apr 17, 2024 •
edited
Loading

Maintainer: me / @xabolcs
Compile tested: ✔️
Run tested: NanoPi R4s (aarch64)

Description:
Fixes: #23924

xabolcs added 2 commits April 18, 2024 00:18
@xabolcs
snapcast: add Snapcast from badaix/snapos as is
981a578 
This will be squashed in the end.

Fixes: openwrt#23924
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
@xabolcs
snapcast: add package snapserver and snapclient
8cf7ce5 
Snapcast [1] is a multiroom client-server audio player, where all
clients are time synchronized with the server to play perfectly synced
audio.

It's not a standalone player, but an extension that turns your existing
audio player into a Sonos-like multiroom solution.
Audio is captured by the server and routed to the connected clients.
Several players can feed audio to the server in parallel and clients can
be grouped to play the same audio stream.
One of the most generic ways to use Snapcast is in conjunction with the
music player daemon (MPD) [1] or Mopidy [2].

[1]: https://github.com/badaix/snapcast
[2]: http://www.musicpd.org/
[3]: https://www.mopidy.com/

Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
@xabolcs xabolcs force-pushed the 23924-snapcast-add-snapserver-and-snapclient-packages branch from b31170a to cbf46ff Compare April 17, 2024 22:42
@davidandreoletti
Copy link
Contributor

davidandreoletti commented Aug 18, 2024 •
edited
Loading

@xabolcs I am interested in this too and already compile snapcast (server) on my end with OpenWRT snapshot. What's missing from your code (and PR) to get merged ?

@xabolcs
Copy link
Contributor Author

xabolcs commented Aug 18, 2024

Hi!

Thaks for testing!

A few things:

  • compile tested on ... ?
  • runtime tested on ... ?
  • ipk sizes?
  • apk compatibility? (e.g. version number)

Adding myself as amaintainer would also help.

@davidandreoletti
Copy link
Contributor

On my end:

  • Compiled snapserver (aarch64) binary on x86-64 machine.
  • Runtime tested on NanoPi R4s (aarch64)
  • ipk sizes (snapserver 0.28.0): 743k
  • apk compatibility? I have not built any APK for OpenWRT so far :-)

@xabolcs
Copy link
Contributor Author

xabolcs commented Aug 18, 2024

Sorry for noob question, but how did you build my branch?

@davidandreoletti
Copy link
Contributor

Sorry for noob question, but how did you build my branch?

I did not build your branch. I thought you were asking about my hardware setup for an eventual test.

@xabolcs
Copy link
Contributor Author

xabolcs commented Aug 19, 2024

OK, thanks for clearing up the misunderstanding! 🙏

I'll let you know when I have packages for you - built from this PR.

@davidandreoletti
Copy link
Contributor

OK, thanks for clearing up the misunderstanding! 🙏

I'll let you know when I have packages for you - built from this PR.

(ping @xabolcs )

@xabolcs
Copy link
Contributor Author

xabolcs commented Jan 15, 2025

Hi @davidandreoletti !

Thanks for the reminder! Sorry, I was carried away! 🙂

Well in the meantime Snapcast 0.29.0 came out which has HTTPS support, but I'm so noob I don't know how to add those dependencies! 🙈
I mean:

Package snapserver is missing dependencies for the following libraries:
libcrypto.so.3
libssl.so.3

Sure, I could stick with 0.28.0. 🤷

@xabolcs xabolcs force-pushed the 23924-snapcast-add-snapserver-and-snapclient-packages branch from cbf46ff to 9f1e2e9 Compare January 15, 2025 09:37
@davidandreoletti
Copy link
Contributor

Stick with 0.28 for this PR.

0.29 dependencies will be investigated in a new PR.

@xabolcs
Copy link
Contributor Author

xabolcs commented Jan 15, 2025 •
edited
Loading

Stick with 0.28 for this PR.

I had to backport a few Boost v1.87.0 compatibility commit for that ... sure its far more easier for me. 👌

@xabolcs xabolcs force-pushed the 23924-snapcast-add-snapserver-and-snapclient-packages branch from 9f1e2e9 to f970ef6 Compare January 17, 2025 21:43
@xabolcs
Copy link
Contributor Author

xabolcs commented Jan 17, 2025 •
edited
Loading

After backporting 3 commits, 0.28.0 is compiling again! 🎉

Here is the result for SNAPSHOT (and apk), please test!
snapcast-apk.tar.gz

@xabolcs
Copy link
Contributor Author

xabolcs commented Jan 18, 2025

Almost there:

Dirty patches detected, please refresh and review the diff
Error: Process completed with exit code 1.

@xabolcs
snapcast: fix compilation with boost 1.87.0
9e81165 
After revisiting the PR, it didn't even compile because of commit
c50de92 ("boost: Updates package to version 1.87.0").

Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
@xabolcs xabolcs force-pushed the 23924-snapcast-add-snapserver-and-snapclient-packages branch from f970ef6 to 9e81165 Compare January 18, 2025 09:46
@xabolcs xabolcs marked this pull request as ready for review January 18, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Snapcast packages (snapserver, snapclient)
2 participants
@xabolcs @davidandreoletti