dockerd: misc maintainence #14816
Merged
dockerd: misc maintainence #14816
+31
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerard Ryan <G.M0N3Y.2503@gmail.com>
Signed-off-by: Gerard Ryan <G.M0N3Y.2503@gmail.com>
* Moved logic out of config writing * Made default config only specify OpenWrt dictated defaults Otherwise, docker defaults can be assumed Signed-off-by: Gerard Ryan <G.M0N3Y.2503@gmail.com>
* Changed from DROP to REJECT to be consistant with other firewall rules Signed-off-by: Gerard Ryan <G.M0N3Y.2503@gmail.com>
Signed-off-by: Gerard Ryan <G.M0N3Y.2503@gmail.com>
Signed-off-by: Gerard Ryan <G.M0N3Y.2503@gmail.com>
|
looks good. We should then also use this in the Openwrt 21.02 branch. |
Agreed. |
feckert
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @G-M0N3Y-2503
Compile tested: x86_x64, VirtualBox, OpenWrt Master
Run tested: x86_x64, VirtualBox, OpenWrt Master
Description:
wanblocking rule now jumps toREJECTinstead ofDROPto be consistent with other firewall rules/etc/config/dockerdwanblocking rule wasn't added if previousiptablescommand was taking too long