Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed unnecessary triggering of celery tasks #283 #325

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jan 27, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • N/A I have updated the documentation.

Reference to Existing Issue

Fixes #283

Description of Changes

Fixed unnecessary triggering of the update_superuser_notification_settings task.

@pandafy
Copy link
Member Author

pandafy commented Jan 27, 2025

The QA is failing because of #324

I have tested this patch with 1.1 versions of openwisp-controller, openwisp-monitoring, openwisp-firmware-upgrader and openwisp-network-topology.

Fixed unnecessary triggering of the
update_superuser_notification_settings task.

Fixes #283
@pandafy pandafy force-pushed the issues/283-update-notificationsetting-task branch from 5c67395 to 36d2c08 Compare January 27, 2025 13:59
@nemesifier nemesifier assigned nemesifier and pandafy and unassigned nemesifier Jan 27, 2025
@nemesifier nemesifier merged commit 0b2173f into master Jan 27, 2025
15 checks passed
@nemesifier nemesifier deleted the issues/283-update-notificationsetting-task branch January 27, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[bug] Task update_superuser_notification_settings may be triggered also when not needed
2 participants