Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added metric name to signal charts. Fixed: #311 #620

Closed
wants to merge 1 commit into from
Closed

Added metric name to signal charts. Fixed: #311 #620

wants to merge 1 commit into from

Conversation

Priyanshu-Batham
Copy link

@Priyanshu-Batham Priyanshu-Batham commented Nov 27, 2024 •
edited
Loading

[change] Added the name of the metric to the label #311

Previously the signal charts didn't have a metric name so the following changes were made.

Signal Strength -> Signal Strength (RSSI)
Signal Power -> Signal Power (RSRP)
Signal Quality -> Signal Quality (RSRQ)
Signal to Noise Ratio -> Signal to Noise Ratio (SNR)

Fixes #311

pandafy
pandafy requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be:

[change] Added the name of the metric to the label #311

Read the contribution guidelines. You can run QA checks locally using ./run-qa-checks

@Priyanshu-Batham Priyanshu-Batham force-pushed the issues/311-add-metric-name-to-label branch from 41d0343 to f49a555 Compare November 27, 2024 15:57
@Priyanshu-Batham
Copy link
Author

@pandafy I updated my commit message from
[openwisp-monitoring/monitoring/configuration.py] Added the name of the metric to the label #311
TO
[change] Added the name of the metric to the label #311

@Priyanshu-Batham
[change] Added the name of the metric to the label #311
7a9f944 
Previously the signal charts didn't have a metric name so the following changes were made.
Signal Strength -> Signal Strength (RSSI)
Signal Power -> Signal Power (RSRP)
Signal Quality -> Signal Quality (RSRQ)
Signal to Noise Ratio -> Signal to Noise Ratio (SNR)

Fixes #311
@Priyanshu-Batham Priyanshu-Batham force-pushed the issues/311-add-metric-name-to-label branch from f49a555 to 7a9f944 Compare November 27, 2024 17:53
@Priyanshu-Batham Priyanshu-Batham deleted the issues/311-add-metric-name-to-label branch November 28, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandafy pandafy Awaiting requested review from pandafy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signal charts: add the name of the metric to the label
2 participants
@Priyanshu-Batham @pandafy