Local indy ledger #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
jakubkoci
requested changes
Aug 26, 2020
Signed-off-by: Timo Glastra <timo@animo.id>
|
@jakubkoci I made some changes based on your feedback. Let me know if you want any other changes |
jakubkoci
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First CI ledger setup used VON-Network. This works great and is easy to setup, but can't be used outside of docker. For CI this is okay, however when developing locally it can become a bit tedious to build the framework into a docker image every time.
This setup works both inside and outside of docker. CI tests are still run inside docker to make the CI setup easier.
Also updated readme with ledger setup and some general improvements.