Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docker setup #72

Merged

Conversation

TimoGlastra
Copy link
Contributor

docker setup now allows to run tests in the docker files. It also makes use of a base indy-nodejs image to reduce build times

to test (from README):

# This build the docker image with all dependencies installed
docker build -t aries-framework-javascript .

# Run tests without network
docker run -it --rm aries-framework-javascript  yarn test -t "agents"

# Run test with network and agencies
docker-compose up # Run alice-agency and bob-agency
docker run -it --rm --network host aries-framework-javascript yarn test

Signed-off-by: Timo Glastra timo@animo.id

docker setup now allows to run tests in the docker files. It also makes use of a base indy-nodejs image to reduce build times

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from jakubkoci July 25, 2020 16:26
@TimoGlastra TimoGlastra requested a review from a team as a code owner July 25, 2020 16:26
Copy link
Contributor

@jakubkoci jakubkoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements 👍

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Contributor Author

@jakubkoci see changes

@jakubkoci jakubkoci merged commit d5c36b8 into openwallet-foundation:master Jul 31, 2020
@TimoGlastra TimoGlastra deleted the docker-improvements branch August 3, 2020 11:53
TimoGlastra added a commit to TimoGlastra/aries-framework-javascript that referenced this pull request Aug 14, 2020
docker setup now allows to run tests in the docker files. It also makes use of a base indy-nodejs image to reduce build times

Signed-off-by: Timo Glastra <timo@animo.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants