Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTE_SDK] expand ModelTemplate.is_global #980

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

leoll2
Copy link
Contributor

@leoll2 leoll2 commented Mar 17, 2022

Add anomaly classification to the list of global tasks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@leoll2 leoll2 added the API Any changes in OTX API label Mar 17, 2022
@leoll2 leoll2 self-assigned this Mar 17, 2022
@leoll2 leoll2 requested a review from a team March 17, 2022 08:54
@leoll2
Copy link
Contributor Author

leoll2 commented Mar 17, 2022

run ote_sdk tests

@leoll2 leoll2 requested a review from druzhkov-paul March 17, 2022 08:55
@nervana-ff
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@druzhkov-paul druzhkov-paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoll2 Please fix ote_sdk/tests/entities/test_model_template.py::TestModelTemplate::test_model_template_is_task_global test.

@druzhkov-paul
Copy link
Contributor

run ote_sdk tests

@leoll2
Copy link
Contributor Author

leoll2 commented Mar 17, 2022

@leoll2
Copy link
Contributor Author

leoll2 commented Mar 18, 2022

run ote_sdk tests

@AlbertvanHouten
Copy link
Contributor

Hey, I have addressed this by updating the TaskType enum (https://jira.devtools.intel.com/browse/CVS-81165) here #983. I think this MR can be closed in favour mine.

@leoll2
Copy link
Contributor Author

leoll2 commented Mar 18, 2022

@AlbertvanHouten Thanks for adding the attribute to TaskType. Rather than closing this MR, I suggest instead to merge it (because ModelTemplate.is_global is currently wrong, we don't want broken code) and immediately open a new ticket to deprecate/remove it and replace any usage in SC and OTE.

@druzhkov-paul druzhkov-paul merged commit abafaa3 into develop Mar 18, 2022
@druzhkov-paul druzhkov-paul deleted the leo/modeltemplate-isglobal branch March 18, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants