[OTE_SDK_TESTS] Added input parameters validation and tests. Part 2 Shapes #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_parameters_validation
|
run ote_sdk tests |
1 similar comment
|
run ote_sdk tests |
…rs for generate_full_box method of Rectangle class
|
Can one of the admins verify this patch? |
|
draft? |
|
This pull request is in the “Draft” state due to unmerged base PR #890, but the approach to check input parameters is ready for review |
…tion_tests # Conflicts: # external/deep-object-reid/submodule # external/mmdetection/submodule # external/mmsegmentation/submodule
…for Shape methods
…tion_tests # Conflicts: # ote_sdk/ote_sdk/tests/parameters_validation/test_shapes_input_parameters_validation.py # ote_sdk/ote_sdk/utils/argument_checks.py
|
@LeonidBeynenson @Ilya-Krylov please review |
|
run ote_sdk tests |
|
run ote-test |
|
closed due to clean up the stale branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added input parameters validations for Shapes classes of OTE SDK:
• Ellipse class: initialization and get_evenly_distributed_ellipse_coordinates methods
• Point class: initialization, normalize_wrt_roi and denormalize_wrt_roi_shape methods
• Polygon class: initialization method
• Rectangle class: initialization, is_full_box and crop_numpy_array methods
• Shape class: initialization, intersects, contains_center, get_labels, append_label, set_labels and _validate_coordinates methods
Tests updated according to above changes:
• test_rectangle.py: test_rectangle_is_full_box
Added tests/parameters_validation/test_shapes_input_parameters_validation.py with negative scenarios to check that ValueError exception is raised when unexpected type object is specified in Shape methods
Task: CVS-77259