Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiling Semantic Seg #3954

Merged
merged 12 commits into from
Sep 22, 2024
Merged

Tiling Semantic Seg #3954

merged 12 commits into from
Sep 22, 2024

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Sep 12, 2024 •
edited
Loading

Summary

Architecture Input Size FM Material Dice (@ov Test) 1 Coliform Dice (@ov Test) 2 Aeromonas Dice (@ov Test) 3 Average Dice Score
litehrnet_18 512x512 0.911360383 0.895190179 0.948441148 0.918997237
litehrnet_s 512x512 0.895577669 0.88297379 0.941476822 0.906676094
litehrnet_x 512x512 0.862190723 0.900618494 0.947349727 0.903386315
segnext_b 512x512 0.906851411 0.901764154 0.942428172 0.917014579
segnext_s 512x512 0.908866405 0.898538351 0.942050934 0.91648523
segnext_t 512x512 0.492610812 0.88449496 0.942346454 0.773150075
dino_v2 560x560 0.856152236 0.856330037 0.900721908 0.871068727

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Sep 16, 2024
@eugene123tw eugene123tw changed the title [Draft] Tiling Semantic Seg Tiling Semantic Seg Sep 16, 2024
@eugene123tw eugene123tw marked this pull request as ready for review September 16, 2024 14:30
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 55.05051% with 89 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (b99770a) to head (9be2eba).

Files with missing lines Patch % Lines
src/otx/core/utils/tile_merge.py 11.11% 32 Missing ⚠️
src/otx/core/model/segmentation.py 28.57% 25 Missing ⚠️
src/otx/core/model/seg_tiler.py 30.43% 16 Missing ⚠️
src/otx/core/data/entity/tile.py 64.70% 12 Missing ⚠️
src/otx/core/data/utils/utils.py 84.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3954      +/-   ##
===========================================
- Coverage    81.64%   81.23%   -0.42%     
===========================================
  Files          288      289       +1     
  Lines        27747    27912     +165     
===========================================
+ Hits         22653    22673      +20     
- Misses        5094     5239     +145
Flag Coverage Δ
py310 ?
py311 81.23% <55.05%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eunwoosh
eunwoosh reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work :) I left some comments. Could you check them?

src/otx/core/data/dataset/tile.py Show resolved Hide resolved
src/otx/core/data/dataset/tile.py Show resolved Hide resolved
src/otx/core/data/entity/tile.py Outdated Show resolved Hide resolved
src/otx/core/model/segmentation.py Outdated Show resolved Hide resolved
src/otx/core/utils/tile_merge.py Outdated Show resolved Hide resolved
src/otx/core/model/seg_tiler.py Show resolved Hide resolved
src/otx/core/model/segmentation.py Show resolved Hide resolved
src/otx/core/utils/tile_merge.py Show resolved Hide resolved
src/otx/core/data/utils/utils.py Show resolved Hide resolved
src/otx/core/data/utils/utils.py Outdated Show resolved Hide resolved
@sovrasov sovrasov added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@sovrasov sovrasov added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@eugene123tw eugene123tw added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@eugene123tw eugene123tw added this pull request to the merge queue Sep 22, 2024
Merged via the queue into openvinotoolkit:develop with commit 40f5ddd Sep 22, 2024
19 checks passed
@eugene123tw eugene123tw deleted the eugene/tiling-semantic-seg-2.3 branch September 22, 2024 22:48
eugene123tw added a commit to eugene123tw/training_extensions that referenced this pull request Sep 23, 2024
@eugene123tw
Tiling Semantic Seg (openvinotoolkit#3954)
a69a1f1 
* tiling-semantic seg

* update recipe

* update unit test

* add unit test

* add test and test dataset

* update test

* refactor tests

* address some comments

* update tile adaptor

* add seg tiler test

* update src/otx/recipe/semantic_segmentation/dino_v2_tile.yaml

* update explain_mode
@sovrasov sovrasov added this to the 2.3.0 milestone Sep 25, 2024
sovrasov added a commit that referenced this pull request Oct 8, 2024
@eugene123tw @sovrasov
MaskDINO ResNet50 (#3977)
d851151 
* update

* add pixel encoders and transformer encoders

* update

* format update

* reformat

* add checkpoint loader

* add custom forward

* udpate

* update postprocess

* fine tune model

* update criterion optimizers etc

* update loss

* replace MSDeformableAttention with native pytorch ops impl

* add export functionality

* roi align mask extraction

* Revert "roi align mask extraction"

This reverts commit b9f9c9a.

* update

* Revert "update"

This reverts commit eb8379b.

* Upgrade OV, MAPI, and NNCF (#3967)

* Tiling Semantic Seg (#3954)

* tiling-semantic seg

* update recipe

* update unit test

* add unit test

* add test and test dataset

* update test

* refactor tests

* address some comments

* update tile adaptor

* add seg tiler test

* update src/otx/recipe/semantic_segmentation/dino_v2_tile.yaml

* update explain_mode

* udpate

* update maskdino from_config

* update maskdino config

* update maskdino config 2

* decouple detectron resnet50

* decouple detectron resnet50

* decouple detectron resnet50

* mypy pylint

* * fix all pylint issues
* sort imports

* remove checkpoint

* update test

* update test

* address comments

* remove inverse_sigmoid

* update weight clip optimizer

* change get_clones to public func

* add tile recipe

* fix export

* remove export names

* optimize denoise training

* optimize denoise training

* refactor inverse sigmoid

* update inverse sigmoid import

* update ptq config

* fix export

* remove private underscore

* update license

* user lightning gradient clipping

* update docstring

* improve loss docstring

* pre commit

* add unit test

* fix test

* reformat

---------

Co-authored-by: Vladislav Sovrasov <sovrasov.vlad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@sovrasov sovrasov sovrasov approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@harimkang harimkang Awaiting requested review from harimkang

@kprokofi kprokofi Awaiting requested review from kprokofi kprokofi is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily

@sungchul2 sungchul2 Awaiting requested review from sungchul2

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81

@yunchu yunchu Awaiting requested review from yunchu

@wonjuleee wonjuleee Awaiting requested review from wonjuleee

Assignees
No one assigned
Labels
TEST Any changes in tests
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eugene123tw @sovrasov @eunwoosh