Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion matrix calculation #3857

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

harimkang
Copy link
Contributor

@harimkang harimkang commented Aug 16, 2024

Summary

https://jira.devtools.intel.com/browse/CVS-149491
but this PR is not root cause resolving

gt and pred idx generated from:

task_labels = resultset.model.configuration.get_label_schema().get_labels(include_empty=True)

image

confusion matrix from:

task_labels = resultset.model.configuration.get_label_schema().get_labels(include_empty=False)

image

above causes a mismatch in the label index.
Unify this to False.

How to test

image

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the API Any changes in OTX API label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (34fdc7c) to head (f35d0a6).
Report is 1 commits behind head on releases/1.6.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.6.0    #3857      +/-   ##
==================================================
- Coverage           80.66%   80.66%   -0.01%     
==================================================
  Files                 536      536              
  Lines               40538    40538              
==================================================
- Hits                32702    32700       -2     
- Misses               7836     7838       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sovrasov sovrasov changed the title Fix confusion metrix calculation Fix confusion matrix calculation Aug 19, 2024
@chuneuny-emily
Copy link
Contributor

@harimkang - Are you going to merge this PR into release/1.6.0? If so, can you update the status "ready"?

@harimkang harimkang marked this pull request as ready for review August 20, 2024 07:54
@harimkang harimkang requested a review from a team as a code owner August 20, 2024 07:54
@harimkang harimkang enabled auto-merge (squash) August 20, 2024 08:50
@chuneuny-emily chuneuny-emily enabled auto-merge (squash) August 20, 2024 08:54
@chuneuny-emily chuneuny-emily merged commit e563f62 into releases/1.6.0 Aug 20, 2024
15 of 17 checks passed
@chuneuny-emily chuneuny-emily deleted the harimkan/fix-confusion-metrix branch August 20, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants