-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update head and h-label format for hierarchical label classification #3810
Update head and h-label format for hierarchical label classification #3810
Conversation
a78c61f
to
89ba872
Compare
d46f73f
to
e6d101a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a few comments, and could you please write some more unit-tests for the classes added to hlabel_cls_head.py
?
Also, it would be great if you could summarize and share the results of experiments comparing the old head to the new head. (cifar100)
- @chuneuny-emily I think we should use cifar100 that sooah used in experiments here for H-label cls large performance tests, what do you think? (There is currently no Large-data case for H-label.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a few minor comments.
b67ead4
to
ed48f15
Compare
ed48f15
to
e524909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I left a minor comment. Please take a look.
Summary
Related to revamp model for h-cls
Update head of h-label cls with CBAM head
Update ground truth format of h-label cls
This is example of cifar100, which has 100 subclasses and 20 superclasses.
Only consider
multi-class
case, so formulti-label
case, I will cover later.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.