Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typ for torch upper version #3775

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Remove typ for torch upper version #3775

merged 1 commit into from
Jul 30, 2024

Conversation

harimkang
Copy link
Contributor

@harimkang harimkang commented Jul 30, 2024

Summary

#3766
I simply checked classification training testing with torch==2.3.1 and it should work with that modification.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to consider XPU support also. Currently, latest torch version IPEX supports is 2.1.3
I requested change to prevent it from merging before dealing with it.

@harimkang
Copy link
Contributor Author

harimkang commented Jul 30, 2024

We need to consider XPU support also. Currently, latest torch version IPEX supports is 2.1.3 I requested change to prevent it from merging before dealing with it.

This is not a PR to upgrade the torch version, it's just a PR to prepare for future changes to _register_pytree_node. Fix it so that it works the same in the current and future versions.

@eunwoosh
Copy link
Contributor

We need to consider XPU support also. Currently, latest torch version IPEX supports is 2.1.3 I requested change to prevent it from merging before dealing with it.

This is not a PR to upgrade the torch version, it's just a PR to prepare for future changes to _register_pytree_node. Fix it so that it works the same in the current and future versions.

Sorry, I misunderstood it as upgrading torch version. Thanks for explanation :)

@harimkang harimkang enabled auto-merge July 30, 2024 06:07
@harimkang harimkang added this to the 2.2.0 milestone Jul 30, 2024
@harimkang harimkang added this pull request to the merge queue Jul 30, 2024
Merged via the queue into openvinotoolkit:develop with commit b42eb4e Jul 30, 2024
18 checks passed
@harimkang harimkang deleted the harimkan/fix-3766 branch July 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants