Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to use polygon and bitmap mask as reference mask for zero-shot learning #3769

Merged
merged 14 commits into from
Jul 30, 2024
Merged

Enable to use polygon and bitmap mask as reference mask for zero-shot learning #3769

merged 14 commits into from
Jul 30, 2024

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Jul 26, 2024 •
edited
Loading

Summary

This PR includes:

  • Enable polygon and bitmap mask as reference mask

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Jul 30, 2024
eunwoosh
eunwoosh reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. I left some comments. Please take a look.

src/otx/core/data/dataset/visual_prompting.py Outdated Show resolved Hide resolved
src/otx/algo/visual_prompting/zero_shot_segment_anything.py Outdated Show resolved Hide resolved
src/otx/core/data/dataset/visual_prompting.py Show resolved Hide resolved
src/otx/core/model/visual_prompting.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Jul 30, 2024
@sungchul2 sungchul2 enabled auto-merge July 30, 2024 07:52
@sungchul2 sungchul2 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into openvinotoolkit:develop with commit e74e5e6 Jul 30, 2024
18 checks passed
@sungchul2 sungchul2 deleted the vpm-polygon-support branch July 30, 2024 11:02
sungchul2 added a commit to sungchul2/training_extensions that referenced this pull request Aug 23, 2024
@sungchul2
(WIP) Revert some parts in openvinotoolkit#3769
4230326
sungchul2 added a commit to sungchul2/training_extensions that referenced this pull request Oct 2, 2024
@sungchul2
Revert some parts in openvinotoolkit#3769
52e63bb
sungchul2 added a commit that referenced this pull request Oct 15, 2024
@sungchul2
Update visual prompting pipeline for multi-label zero-shot learning s…
78b560d 
…upport (#3993)

* Add flag for using mask or polygon in `learn`

* Revert some parts in #3769

* Fix metric

* Fix unit test

* Fix

* Fix unit tests

* Fix integration test

* Update docstring

* Fix error during ptq

* Update CHANGELOG

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@sovrasov sovrasov sovrasov approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@harimkang harimkang Awaiting requested review from harimkang

@vinnamkim vinnamkim Awaiting requested review from vinnamkim

@eugene123tw eugene123tw Awaiting requested review from eugene123tw eugene123tw is a code owner

@kprokofi kprokofi Awaiting requested review from kprokofi kprokofi is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81

@yunchu yunchu Awaiting requested review from yunchu

@wonjuleee wonjuleee Awaiting requested review from wonjuleee

Assignees
No one assigned
Labels
DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sungchul2 @sovrasov @eunwoosh