-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DataModuleConfig for the reduced config structure #3688
Conversation
d7af88f
to
67b40d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good.
But I see that otx.core.config.data
hasn't been cleared yet, will you be removing these in the next PR (DataModuleConfig, SubsetConfig, etc...)?
Also, due to the size of this PR, I think the integration test results should be shared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your huge effort :) Could you update integration test result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's check integation test results.
3e9be78
to
326c7f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.