Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataModuleConfig for the reduced config structure #3688

Merged
merged 15 commits into from
Jul 2, 2024

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@wonjuleee wonjuleee marked this pull request as draft June 27, 2024 04:27
@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Jun 27, 2024
@wonjuleee wonjuleee marked this pull request as ready for review June 27, 2024 05:58
@wonjuleee wonjuleee added API Any changes in OTX API CLI Any changes in OTE CLI and removed TEST Any changes in tests OTX 2.0 labels Jun 27, 2024
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good.
But I see that otx.core.config.data hasn't been cleared yet, will you be removing these in the next PR (DataModuleConfig, SubsetConfig, etc...)?

Also, due to the size of this PR, I think the integration test results should be shared.

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Jun 27, 2024
@harimkang harimkang added this to the 2.2.0 milestone Jun 28, 2024
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your huge effort :) Could you update integration test result?

vinnamkim
vinnamkim previously approved these changes Jun 28, 2024
Copy link
Contributor

@sungchul2 sungchul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's check integation test results.

Copy link
Contributor Author

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Here is the integration test results. This PR passed 339 tests, while this has 8 failures on yolox explanations. But this is known issue in the develop.

@wonjuleee wonjuleee enabled auto-merge (squash) July 2, 2024 07:12
@wonjuleee wonjuleee merged commit 88b2602 into openvinotoolkit:develop Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API CLI Any changes in OTE CLI TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants