Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Vitens Kiemgetal OTX 1.6.x #3671

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Jun 24, 2024

Summary

  • Remove the maximum number of detections from the tile adaptor and make it manually configurable.
    • e.g. otx train --workspace=... params --tiling_parameters.enable_tiling=true --tiling_parameters.tile_max_number=200
  • Remove random affine and color augmentation for YOLOX and ATSS tile recipes.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added CLI Any changes in OTE CLI ALGO Any changes in OTX Algo Tasks implementation labels Jun 24, 2024
@github-actions github-actions bot added the TEST Any changes in tests label Jul 17, 2024
@github-actions github-actions bot removed the CLI Any changes in OTE CLI label Jul 17, 2024
@eugene123tw eugene123tw changed the title [Draft] Improve Vitens OTX 1.6.x Improve Vitens Kiemgetal OTX 1.6.x Jul 17, 2024
@eugene123tw eugene123tw marked this pull request as ready for review July 17, 2024 11:43
@eugene123tw eugene123tw requested a review from a team as a code owner July 17, 2024 11:43
@eugene123tw eugene123tw marked this pull request as draft July 17, 2024 11:45
@eugene123tw eugene123tw marked this pull request as ready for review July 18, 2024 09:35
chuneuny-emily
chuneuny-emily previously approved these changes Jul 18, 2024
sovrasov
sovrasov previously approved these changes Jul 18, 2024
@sovrasov
Copy link
Contributor

sovrasov commented Jul 18, 2024

@eugene123tw CI is not working for this branch, since all workers were moved to AWS.
Could you run linters, unit & tiling detection integration tests manually?

@eugene123tw
Copy link
Contributor Author

image

@eugene123tw eugene123tw dismissed stale reviews from sovrasov and chuneuny-emily via bbde220 July 18, 2024 13:51
@eugene123tw
Copy link
Contributor Author

image

@eugene123tw
Copy link
Contributor Author

eugene123tw commented Jul 18, 2024

tests/integration/cli/instance_segmentation/test_tiling_instseg.py

image

pytest tests/integration/cli/detection/test_tiling_detection.py

image

@chuneuny-emily chuneuny-emily merged commit 2c278b2 into openvinotoolkit:releases/1.6.0 Jul 19, 2024
3 checks passed
@eugene123tw eugene123tw deleted the eugene/kiemgetal-improvement-1.6.x branch September 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants