Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data_format validation and update in OTXDataModule #3579

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add data_format validation and update in OTXDataModule #3579

merged 2 commits into from
Jun 5, 2024

Conversation

harimkang
Copy link
Contributor

Summary

#3227
Validates the structure of the dataset and replaces any invalid data_format.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Jun 4, 2024
@harimkang harimkang marked this pull request as ready for review June 4, 2024 15:36
@harimkang harimkang changed the title Add data_format validation and replacement code in OTXDataModule Add data_format validation and update in OTXDataModule Jun 5, 2024
@harimkang harimkang mentioned this pull request Jun 5, 2024
Open
@harimkang harimkang enabled auto-merge (squash) June 5, 2024 05:28
@harimkang harimkang added this to the 2.1.0 milestone Jun 5, 2024
@harimkang harimkang disabled auto-merge June 5, 2024 08:26
@harimkang harimkang merged commit bff953e into openvinotoolkit:develop Jun 5, 2024
13 checks passed
@harimkang harimkang mentioned this pull request Jul 22, 2024
Merged
8 tasks
harimkang added a commit that referenced this pull request Jul 22, 2024
@harimkang
Revert #3579 (#3753)
7109b1a
github-merge-queue bot pushed a commit that referenced this pull request Aug 6, 2024
@yunchu @harimkang
Mergeback 2.1.0 to develop (#3787)
f618a37 
* Revert #3579 (#3753)

* remove config attributes on OTXDataModule

* remove dataformat check test

---------

Co-authored-by: Harim Kang <harim.kang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@kprokofi kprokofi kprokofi approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@vinnamkim vinnamkim Awaiting requested review from vinnamkim

@jaegukhyun jaegukhyun Awaiting requested review from jaegukhyun

@eugene123tw eugene123tw Awaiting requested review from eugene123tw eugene123tw is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily

@sovrasov sovrasov Awaiting requested review from sovrasov sovrasov is a code owner

@sungchul2 sungchul2 Awaiting requested review from sungchul2

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81

@yunchu yunchu Awaiting requested review from yunchu

@wonjuleee wonjuleee Awaiting requested review from wonjuleee

Assignees
No one assigned
Labels
TEST Any changes in tests
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harimkang @kprokofi @eunwoosh