Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some export issues. Remove EXPORTABLE_CODE as export parameter. #3577

Merged
merged 14 commits into from
Jun 5, 2024

Conversation

kprokofi
Copy link
Collaborator

@kprokofi kprokofi commented Jun 3, 2024

Summary

  1. Fix exportable code issue CVS-142373, checked that CVS-142263 isn't reproduced, added changes according to CVS-135469

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

harimkang
harimkang previously approved these changes Jun 4, 2024
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work :) I left some comments. Please take a look.

src/otx/core/model/base.py Outdated Show resolved Hide resolved
src/otx/core/model/base.py Show resolved Hide resolved
src/otx/engine/engine.py Show resolved Hide resolved
src/otx/core/exporter/base.py Show resolved Hide resolved
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (52897e2) to head (06eefc5).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/otx/core/model/base.py 16.66% 5 Missing ⚠️
src/otx/engine/engine.py 50.00% 3 Missing ⚠️
src/otx/core/exporter/base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3577   +/-   ##
========================================
  Coverage    83.25%   83.25%           
========================================
  Files          255      255           
  Lines        25188    25199   +11     
========================================
+ Hits         20970    20980   +10     
- Misses        4218     4219    +1     
Flag Coverage Δ
py310 82.89% <47.05%> (-0.08%) ⬇️
py311 83.20% <47.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kprokofi kprokofi merged commit 8c8bf55 into develop Jun 5, 2024
14 of 15 checks passed
@kprokofi kprokofi deleted the kp/fix_export branch June 5, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants