Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in Semantic Segmentation + enable DINOV2 export in ONNX #3569

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

kprokofi
Copy link
Collaborator

@kprokofi kprokofi commented Jun 2, 2024

Summary

  1. Only without registers DINOV2 can be exported to ONNX. The accuracy difference is insignificant
  2. Bug fix with ignore index in labels pre-filtering. Bug fix with overriding default values in segmentation models

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.24%. Comparing base (ec0f906) to head (b88be34).
Report is 4 commits behind head on develop.

Files Patch % Lines
src/otx/core/data/pre_filtering.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3569      +/-   ##
===========================================
+ Coverage    83.14%   83.24%   +0.09%     
===========================================
  Files          254      255       +1     
  Lines        24955    25191     +236     
===========================================
+ Hits         20749    20969     +220     
- Misses        4206     4222      +16     
Flag Coverage Δ
py310 83.22% <90.90%> (+0.09%) ⬆️
py311 82.96% <90.90%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kprokofi kprokofi requested a review from eunwoosh June 3, 2024 16:18
@kprokofi kprokofi added this to the 2.1.0 milestone Jun 3, 2024
@kprokofi kprokofi merged commit 42b227a into develop Jun 4, 2024
15 checks passed
@kprokofi kprokofi deleted the kp/fix_dinov2 branch June 4, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants