-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Perf test available to load pervious Perf test to skip training stage #3556
Merged
sovrasov
merged 8 commits into
openvinotoolkit:develop
from
eunwoosh:perf_get_prev_train
May 30, 2024
Merged
Make Perf test available to load pervious Perf test to skip training stage #3556
sovrasov
merged 8 commits into
openvinotoolkit:develop
from
eunwoosh:perf_get_prev_train
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodsong81
requested changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature & refactoring!
I have a few minor comments. Feel free to accept or not (except for the typos ;p)
goodsong81
previously approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sovrasov
reviewed
May 29, 2024
eunwoosh
requested review from
samet-akcay,
harimkang,
vinnamkim,
jaegukhyun,
eugene123tw,
kprokofi,
chuneuny-emily,
sungchul2,
GalyaZalesskaya,
negvet,
yunchu and
wonjuleee
as code owners
May 30, 2024 00:20
goodsong81
approved these changes
May 30, 2024
harimkang
approved these changes
May 30, 2024
sovrasov
approved these changes
May 30, 2024
eunwoosh
added a commit
to eunwoosh/training_extensions
that referenced
this pull request
Jun 5, 2024
…stage (openvinotoolkit#3556) * symlink to relative path * skip training if prev perf result exists * implement missing part * align with pre-commit * udpate test code * fix typo * change arg name to resume-from * revert checkpoint symlink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds new features that Perf test can skip training stage by loading previous Perf test.
If previous perf test result directory is given as an argument,
Perf test can check training w/ same tags (
["data_group", "data", "model", "task", "seed"]
) was already done, and skip training stage if possible.This feature can provide two use cases:
Additionally, this PR includes
./latest
, sym link refers relative path not absolute pathHow to test
Checklist
License
Feel free to contact the maintainers if that's a concern.