-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync rgb order between torch and ov inference of action classification task #3551
Sync rgb order between torch and ov inference of action classification task #3551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I left a comment. Please take a look.
@jaegukhyun I updated |
@sungchul2 |
Right. Without this update, your below change is meaningless because otx in develop doesn't reflect |
Thanks for the notice. Currently action task do not use image color channel both on torch and ov inference, but torch and ov inference use different format. This PR is trying to sync the default color format of torch and ov inference. After this PR we need to link image_color_channel for torch and ov inference of action classification. At that PR we need to consider your point |
Summary
This PR is for synchronize RGB order of ov inference and torch inference in action classification task
Currently action classification requires video loading for inference. For torch model inference OTX use video loading pipeline from mmaction. And for ov model inference OTX use datumaro video loading pipeline.
MMAction loads video as BGR format and Datumaro loads video as RGB format.
I'm not sure the pretrained weight is trained by BGR or RGB.
Therefore, we need additional PR to sync between pretrained weights and torch, ov inference
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.