Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMDet RTMDet Inst decoupling #3433

Conversation

eugene123tw
Copy link
Collaborator

@eugene123tw eugene123tw commented May 1, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eugene123tw eugene123tw deleted the eugene/CVS-139534-rtmdet-decoupling branch May 7, 2024 09:53
@eugene123tw eugene123tw restored the eugene/CVS-139534-rtmdet-decoupling branch May 7, 2024 09:54
@eugene123tw eugene123tw reopened this May 7, 2024
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM
Let me know if the test passes.

@eugene123tw eugene123tw requested a review from harimkang May 7, 2024 14:35
harimkang
harimkang previously approved these changes May 7, 2024
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I left some comments. If instance segmentation models are fully decoupled from mmdet, I guess next PR might

  1. Remove mmengine registry import in detection algo folder.
  2. Remove unnecessary mmengine or mmdet import in iseg algo folder

harimkang
harimkang previously approved these changes May 8, 2024
jaegukhyun
jaegukhyun previously approved these changes May 8, 2024
@harimkang harimkang enabled auto-merge (squash) May 9, 2024 00:10
@harimkang harimkang merged commit 3f32845 into openvinotoolkit:releases/2.0.0 May 9, 2024
13 checks passed
@eugene123tw eugene123tw deleted the eugene/CVS-139534-rtmdet-decoupling branch May 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants