-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMDet RTMDet Inst decoupling #3433
MMDet RTMDet Inst decoupling #3433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM
Let me know if the test passes.
src/otx/algo/instance_segmentation/mmdet/models/dense_heads/rtmdet_ins_head.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. I left some comments. If instance segmentation models are fully decoupled from mmdet, I guess next PR might
- Remove mmengine registry import in detection algo folder.
- Remove unnecessary mmengine or mmdet import in iseg algo folder
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.