Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mm related configs #3419

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Remove mm related configs #3419

merged 9 commits into from
Apr 30, 2024

Conversation

jaegukhyun
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Apr 29, 2024
@jaegukhyun jaegukhyun marked this pull request as ready for review April 29, 2024 10:55
eugene123tw
eugene123tw previously approved these changes Apr 29, 2024
View reviewed changes
@eugene123tw eugene123tw self-requested a review April 29, 2024 15:24
harimkang
harimkang previously approved these changes Apr 30, 2024
View reviewed changes
wonjuleee
wonjuleee previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great! I have left minor questions.

@jaegukhyun jaegukhyun dismissed stale reviews from wonjuleee, harimkang, and eugene123tw via 95f062d April 30, 2024 02:11
@jaegukhyun jaegukhyun requested a review from wonjuleee April 30, 2024 04:13
@jaegukhyun jaegukhyun merged commit c4422f5 into openvinotoolkit:develop Apr 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene123tw eugene123tw eugene123tw approved these changes

@harimkang harimkang harimkang approved these changes

@sungchul2 sungchul2 sungchul2 approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@vinnamkim vinnamkim Awaiting requested review from vinnamkim

@kprokofi kprokofi Awaiting requested review from kprokofi kprokofi is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily

@sovrasov sovrasov Awaiting requested review from sovrasov sovrasov is a code owner

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81

@yunchu yunchu Awaiting requested review from yunchu

@eunwoosh eunwoosh Awaiting requested review from eunwoosh

@wonjuleee wonjuleee Awaiting requested review from wonjuleee

Assignees
No one assigned
Labels
TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaegukhyun @eugene123tw @harimkang @wonjuleee @sungchul2