Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use BaseModule on detection #3415

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

sungchul2
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Apr 29, 2024
@jaegukhyun
Copy link
Contributor

Could you check init_weights functions are fully migrated? I think some modules in otx/algo/detection miss their original init_weights function.

@sungchul2
Copy link
Contributor Author

Could you check init_weights functions are fully migrated? I think some modules in otx/algo/detection miss their original init_weights function.

Done at c9a8562.

@sungchul2 sungchul2 force-pushed the use_basemodule_detector branch from 03012b2 to ec44eb9 Compare April 29, 2024 08:18
@sungchul2 sungchul2 enabled auto-merge (squash) April 30, 2024 00:03
@sungchul2 sungchul2 requested a review from jaegukhyun April 30, 2024 00:40
@sungchul2 sungchul2 merged commit 78db02b into openvinotoolkit:develop Apr 30, 2024
13 checks passed
@sungchul2 sungchul2 deleted the use_basemodule_detector branch April 30, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants