-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple semantic segmentation models #3376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Could you share some regression tests between decoupling?
In some case torchvision data pipeline slower than mm's pipeline since mm use opencv and it is faster than torch tensor ops.
So we need regression tests results for accuracy and e2e time.
src/otx/algo/segmentation/losses/cross_entropy_loss_with_ignore.py
Outdated
Show resolved
Hide resolved
And it seems unit tests run on cpu machine. So I think you need to fix unit tests failure on cpu machine. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3376 +/- ##
===========================================
- Coverage 77.30% 76.59% -0.72%
===========================================
Files 250 255 +5
Lines 22828 23281 +453
===========================================
+ Hits 17648 17831 +183
- Misses 5180 5450 +270
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tests are passed. I propose to merge this PR, since today is FF. I compared algorithms on KITTI dataset. iter_time is the same, data_train_time is worse on 0.002 sec., due to difference in resizing and augmentations, we have changed accuracy values about 2-4 % DICE score on this dataset. We need to align augmentations with mm* |
Summary
Eliminate mmseg dependency for models, decouple all models, introduce updated model structure, added support for torchvision data pipeline
Unit tests will be added with next PRs.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.