Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic seg ground truth mask extraction #3270

Merged

Conversation

vinnamkim
Copy link
Contributor

Summary

  • Let ignore_index working correctly.
  • Merge individual masks into a class mask (semantic mask) correctly.

How to test

Added an unit test to validate ignore_index

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

 - ignore_index is now correctly working

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.71%. Comparing base (0db2e80) to head (023d3ee).

Files Patch % Lines
src/otx/core/data/dataset/segmentation.py 88.57% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3270      +/-   ##
===========================================
+ Coverage    79.69%   79.71%   +0.02%     
===========================================
  Files          180      180              
  Lines        15365    15398      +33     
===========================================
+ Hits         12245    12275      +30     
- Misses        3120     3123       +3     
Flag Coverage Δ
py310 79.71% <89.18%> (+0.02%) ⬆️
py311 79.71% <89.18%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harimkang
harimkang previously approved these changes Apr 4, 2024
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit 61196fa into openvinotoolkit:develop Apr 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants