Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XAI data entities #3230

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

vinnamkim
Copy link
Contributor

Summary

  • Ticket no. 135930
  • This PR aims to remove *PredEntityWithXAI and merge the fields owned by it into *PredEntity.
  • It is because it doubles the number of entities in the data entity codebase and makes OTXModel’s generic typing too complicated.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Mar 28, 2024
@vinnamkim vinnamkim force-pushed the refactor-xai-part-1 branch from 013f4f4 to a554467 Compare March 28, 2024 10:24
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 59.82143% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 71.37%. Comparing base (9a47ee8) to head (a4b7552).

Files Patch % Lines
src/otx/core/model/classification.py 33.33% 6 Missing ⚠️
src/otx/core/data/entity/anomaly/classification.py 0.00% 4 Missing ⚠️
src/otx/core/data/entity/anomaly/detection.py 0.00% 4 Missing ⚠️
src/otx/core/data/entity/anomaly/segmentation.py 0.00% 4 Missing ⚠️
src/otx/core/data/entity/action_detection.py 0.00% 3 Missing ⚠️
src/otx/core/data/transform_libs/torchvision.py 0.00% 3 Missing ⚠️
src/otx/core/data/dataset/visual_prompting.py 50.00% 2 Missing ⚠️
src/otx/core/data/entity/base.py 90.00% 2 Missing ⚠️
src/otx/core/data/entity/classification.py 75.00% 2 Missing ⚠️
src/otx/core/data/entity/visual_prompting.py 60.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3230      +/-   ##
===========================================
+ Coverage    71.25%   71.37%   +0.12%     
===========================================
  Files          178      178              
  Lines        15162    15092      -70     
===========================================
- Hits         10803    10772      -31     
+ Misses        4359     4320      -39     
Flag Coverage Δ
py310 71.34% <59.82%> (+0.11%) ⬆️
py311 71.37% <59.82%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim added this to the 2.1.0 milestone Mar 29, 2024
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great update that will help us :)

@vinnamkim vinnamkim merged commit f1f55e2 into openvinotoolkit:develop Mar 29, 2024
15 of 16 checks passed
@vinnamkim vinnamkim deleted the refactor-xai-part-1 branch March 29, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants