-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor optimizer and lr scheduler part #3216
Merged
vinnamkim
merged 9 commits into
openvinotoolkit:develop
from
vinnamkim:refactor-optimizer-and-lr-scheduler
Mar 29, 2024
Merged
Refactor optimizer and lr scheduler part #3216
vinnamkim
merged 9 commits into
openvinotoolkit:develop
from
vinnamkim:refactor-optimizer-and-lr-scheduler
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3216 +/- ##
===========================================
+ Coverage 70.30% 73.48% +3.18%
===========================================
Files 178 179 +1
Lines 15162 15232 +70
===========================================
+ Hits 10659 11193 +534
+ Misses 4503 4039 -464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
harimkang
reviewed
Mar 28, 2024
src/otx/algo/classification/mmconfigs/multiclass_classification/dino_v2.yaml
Show resolved
Hide resolved
Co-authored-by: Harim Kang <harim.kang@intel.com>
jaegukhyun
approved these changes
Mar 28, 2024
harimkang
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket no. 135933
This PR aims to remove the custom code in
src/otx/cli/cli.py
which is hardly coupled withOTXModel
.To do this, change type
optimizer
andscheduler
typings fromto
This is to remove the
list[OptimizerCallable]
andlist[LRSchedulerCallable]
typings. The reason for this is that I faced this issue, [Question] Is it possible to change the init_args of list elements with giving ActionConfigFile omni-us/jsonargparse#478, after removingadd_list_type_arguments()
fromsrc/otx/cli/cli.py
.According to this type change, it is required to implement
LinearWarmupSchedulerCallable
newly to incorporate the linear warmup scheduler with the other main scheduler.LinearWarmupSchedulerCallable
andOTXModel.lr_scheduler_step()
will solve this problem, Fix multiple lr scheduler (warmup scheduler) & Add adaptive_patience to the lr scheduler #3035 (comment)How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.