Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support perf result reference check for benchmark v2 #3140

Merged
merged 14 commits into from
Mar 15, 2024

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Mar 15, 2024

Summary

  • Add reference data & check method
  • Support otx-ref which enables benchmarking other versions of otx on this repo
    image
  • Rename data-size -> data-group
  • Add weekly workflow
  • Fix a few issues

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests BUILD labels Mar 15, 2024
@goodsong81 goodsong81 requested a review from yunchu March 15, 2024 08:53
@goodsong81 goodsong81 marked this pull request as ready for review March 15, 2024 08:54
@goodsong81 goodsong81 added this to the 2.0.0 milestone Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.40%. Comparing base (01a74f1) to head (a24ea97).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3140   +/-   ##
========================================
  Coverage    64.39%   64.40%           
========================================
  Files          259      259           
  Lines        15290    15290           
========================================
+ Hits          9846     9847    +1     
+ Misses        5444     5443    -1     
Flag Coverage Δ
py310 64.40% <ø> (+<0.01%) ⬆️
py311 64.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goodsong81 goodsong81 merged commit 0b572cc into develop Mar 15, 2024
15 checks passed
@goodsong81 goodsong81 deleted the test/perf-check-ref-v2 branch March 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants