Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong ov datamodule update in predict, test, optimize #3139

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Fix wrong ov datamodule update in predict, test, optimize #3139

merged 7 commits into from
Mar 19, 2024

Conversation

harimkang
Copy link
Contributor

Summary

Fix https://jira.devtools.intel.com/browse/CVS-135468

Found that changing the OV test pipeline was causing a behavior that changed not only the transforms, but also other data-related configs, so fix around it.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.18%. Comparing base (106c111) to head (13ac068).

Files Patch % Lines
src/otx/engine/engine.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3139      +/-   ##
===========================================
+ Coverage    64.14%   64.18%   +0.04%     
===========================================
  Files          182      182              
  Lines        15061    15067       +6     
===========================================
+ Hits          9661     9671      +10     
+ Misses        5400     5396       -4     
Flag Coverage Δ
py310 64.18% <73.33%> (+0.04%) ⬆️
py311 64.18% <73.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jaegukhyun
jaegukhyun previously approved these changes Mar 15, 2024
src/otx/engine/engine.py Outdated Show resolved Hide resolved
@harimkang harimkang merged commit 021e793 into openvinotoolkit:develop Mar 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants