Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate v2 branch to develop #3102

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Migrate v2 branch to develop #3102

merged 5 commits into from
Mar 14, 2024

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Mar 14, 2024

Summary

This PR is for migrating v2 branch to develop.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@yunchu yunchu requested review from a team as code owners March 14, 2024 08:48
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM API Any changes in OTX API CLI Any changes in OTE CLI ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests BUILD DOC Improvements or additions to documentation labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 74.82550% with 541 lines in your changes are missing coverage. Please review.

Project coverage is 61.55%. Comparing base (eaae856) to head (b150b5e).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/otx/algo/classification/deit_tiny.py 0.00% 93 Missing ⚠️
...c/otx/algo/action_classification/openvino_model.py 28.78% 47 Missing ⚠️
...tx/algo/action_classification/backbones/movinet.py 81.97% 42 Missing ⚠️
.../algo/classification/backbones/otx_efficientnet.py 84.61% 38 Missing ⚠️
src/otx/algo/classification/otx_dino_v2.py 53.52% 33 Missing ⚠️
src/otx/algo/classification/efficientnet_v2.py 0.00% 27 Missing ⚠️
src/otx/algo/detection/losses/cross_focal_loss.py 61.29% 24 Missing ⚠️
src/otx/algo/classification/mobilenet_v3_large.py 47.72% 23 Missing ⚠️
src/otx/algo/classification/torchvision_model.py 78.12% 21 Missing ⚠️
src/otx/algo/detection/atss.py 52.63% 18 Missing ⚠️
... and 22 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3102       +/-   ##
============================================
- Coverage    80.75%   61.55%   -19.20%     
============================================
  Files          536      259      -277     
  Lines        40408    15278    -25130     
============================================
- Hits         32631     9405    -23226     
+ Misses        7777     5873     -1904     
Flag Coverage Δ
py310 61.55% <74.82%> (?)
py311 61.55% <74.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu enabled auto-merge (squash) March 14, 2024 12:14
@yunchu yunchu merged commit 76f2313 into develop Mar 14, 2024
13 of 15 checks passed
@yunchu yunchu deleted the migrate-v2-to-develop branch March 14, 2024 12:25
@yunchu yunchu restored the migrate-v2-to-develop branch March 15, 2024 01:08
yunchu added a commit that referenced this pull request Mar 15, 2024
yunchu added a commit that referenced this pull request Mar 15, 2024
Revert "Migrate v2 branch to develop (#3102)"

This reverts commit 76f2313.
@yunchu yunchu mentioned this pull request Mar 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API BUILD CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants