Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change code using fixed subset name in HPO #3101

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Mar 14, 2024

Summary

This PR changes code using fixed subset name in hpo_api.py
In addition to that, I changed HPO code to raise error once one of HPO trials exit abnormally.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 66.28%. Comparing base (a50ac7f) to head (15d94b2).

Files Patch % Lines
src/otx/hpo/hpo_runner.py 0.00% 4 Missing ⚠️
src/otx/engine/hpo/hpo_api.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3101   +/-   ##
========================================
  Coverage    66.27%   66.28%           
========================================
  Files          176      176           
  Lines        14931    14925    -6     
========================================
- Hits          9896     9893    -3     
+ Misses        5035     5032    -3     
Flag Coverage Δ
py310 66.28% <0.00%> (+<0.01%) ⬆️
py311 66.28% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eunwoosh eunwoosh changed the base branch from v2 to develop March 18, 2024 02:33
harimkang
harimkang previously approved these changes Mar 19, 2024
@harimkang
Copy link
Contributor

Please modify the target with this to the releases/2.0.0 branch.

@harimkang harimkang added this to the 2.0.0 milestone Mar 21, 2024
@github-actions github-actions bot added the TEST Any changes in tests label Mar 22, 2024
@eunwoosh
Copy link
Contributor Author

Please modify the target with this to the releases/2.0.0 branch.

I'll open same PR for releases/2.0.0 after it's merged.

@eunwoosh eunwoosh requested review from harimkang and vinnamkim March 22, 2024 08:26
@vinnamkim vinnamkim merged commit 77b470c into openvinotoolkit:develop Mar 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants