Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warmup scheduler and add patience update for adaptive interval #3056

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Mar 7, 2024

Summary

The goal of this PR is the same as this PR: #3035
However, simpler way.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.79%. Comparing base (ac4c2c6) to head (ea1b11a).

Files Patch % Lines
src/otx/algo/schedulers/warmup_schedulers.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #3056      +/-   ##
==========================================
+ Coverage   56.75%   56.79%   +0.04%     
==========================================
  Files         250      250              
  Lines       14656    14672      +16     
==========================================
+ Hits         8318     8333      +15     
- Misses       6338     6339       +1     
Flag Coverage Δ
py310 56.79% <93.33%> (+0.04%) ⬆️
py311 56.79% <93.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've organized the detection results of the previous PR in OneNote, could you check against that to see if it really behaves the same?

@jaegukhyun jaegukhyun merged commit f36a6ae into openvinotoolkit:v2 Mar 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants