Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hlabel parent resolver and integrate HLabelData + HLabelInfo --> HLabelInfo #3046

Merged
merged 18 commits into from
Mar 11, 2024

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Mar 6, 2024

Summary

This PR introduces,

  • Integrate the classes: HLabelData + HLabelInfo --> HLabelInfo : previously, it's hierarchy useless. So, integrated.
  • Add _add_ancestor function to the HLabelDataset, so OTXv2 could get the ancestor annotation when it's not included.
  • Change the tests/assets data to check the case that miss the parent information.
  • Change the fixture to explain the HLabel case more easily

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Mar 6, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 84.74576% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 59.34%. Comparing base (506a22f) to head (471b7a9).

Files Patch % Lines
src/otx/core/model/module/classification.py 0.00% 10 Missing ⚠️
src/otx/core/data/dataset/classification.py 92.77% 6 Missing ⚠️
src/otx/core/model/entity/classification.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #3046      +/-   ##
==========================================
+ Coverage   59.04%   59.34%   +0.30%     
==========================================
  Files         253      253              
  Lines       14952    14984      +32     
==========================================
+ Hits         8829     8893      +64     
+ Misses       6123     6091      -32     
Flag Coverage Δ
py310 59.34% <84.74%> (+0.30%) ⬆️
py311 59.34% <84.74%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vinnamkim
vinnamkim previously approved these changes Mar 11, 2024
harimkang
harimkang previously approved these changes Mar 11, 2024
jaegukhyun
jaegukhyun previously approved these changes Mar 11, 2024
@sungmanc sungmanc dismissed stale reviews from jaegukhyun, harimkang, and vinnamkim via 471b7a9 March 11, 2024 02:28
@sungmanc sungmanc merged commit 8737903 into openvinotoolkit:v2 Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants