Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimize for visual prompting to 2.0 #3040

Merged
merged 69 commits into from
Mar 11, 2024

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Mar 6, 2024

Summary

This PR includes:

  • optimize
    • inference results (fine-tuning, #test=150)

      torch (F32, GPU) torch (F32, CPU) OVIR (F32, CPU) OVIR (I8, CPU)
      F1 91.30 91.30 91.40 87.99
      e2e time 34s 99s 69s 53s
    • inference results (zero-shot, #test=150)

      torch (F32, GPU) torch (F32, CPU) OVIR (F32, CPU) OVIR (I8, CPU)
      F1 67.19 67.19 67.72 55.53
      e2e 12s 108s 80s 113s
  • updates
    • export_params
    • _inspect_overlapping_areas

TODO

  • demo scenario of exportable_code for visual prompting tasks should be decided.
  • segmentation fault occurs after optimize with current openvino version (2023.3).

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 58.84%. Comparing base (854747a) to head (e3d29ae).
Report is 1 commits behind head on v2.

Files Patch % Lines
src/otx/core/model/entity/visual_prompting.py 68.11% 22 Missing ⚠️
...lgo/visual_prompting/zero_shot_segment_anything.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #3040      +/-   ##
==========================================
+ Coverage   56.65%   58.84%   +2.19%     
==========================================
  Files         250      250              
  Lines       14691    14766      +75     
==========================================
+ Hits         8323     8689     +366     
+ Misses       6368     6077     -291     
Flag Coverage Δ
py310 58.84% <66.66%> (+2.19%) ⬆️
py311 58.84% <66.66%> (+2.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vinnamkim
vinnamkim previously approved these changes Mar 8, 2024
@sungchul2 sungchul2 requested a review from vinnamkim March 8, 2024 05:32
@sungchul2 sungchul2 merged commit 506a22f into openvinotoolkit:v2 Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants