Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt mask prediction to rotated box prediction #3029

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Adapt mask prediction to rotated box prediction #3029

merged 8 commits into from
Mar 11, 2024

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Mar 4, 2024 •
edited
Loading

Summary

Adapt mask prediction to rotated box prediction

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eugene123tw eugene123tw changed the title Eugene/cvs 134533 rotated pred [Draft] Rotated pred Mar 4, 2024
@eugene123tw eugene123tw changed the title [Draft] Rotated pred Adapt mask prediction to rotated box prediction Mar 5, 2024
@eugene123tw eugene123tw marked this pull request as ready for review March 5, 2024 09:05
vinnamkim
vinnamkim previously approved these changes Mar 6, 2024
View reviewed changes
harimkang
harimkang previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
and may I ask if you could add a test case to test this?

@eugene123tw eugene123tw dismissed stale reviews from harimkang and vinnamkim via 31e8200 March 6, 2024 10:24
@github-actions github-actions bot added the TEST Any changes in tests label Mar 6, 2024
@harimkang harimkang enabled auto-merge (squash) March 7, 2024 00:30
@harimkang
Copy link
Contributor

@sungmanc @jaegukhyun Take a look and if you see nothing wrong, please approve.

@harimkang harimkang merged commit 5000bd9 into openvinotoolkit:v2 Mar 11, 2024
10 checks passed
@eugene123tw eugene123tw deleted the eugene/CVS-134533-rotated-pred branch March 11, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@harimkang harimkang harimkang approved these changes

@vinnamkim vinnamkim vinnamkim approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@sungmanc sungmanc Awaiting requested review from sungmanc sungmanc is a code owner

@kprokofi kprokofi Awaiting requested review from kprokofi kprokofi is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner

@sovrasov sovrasov Awaiting requested review from sovrasov sovrasov is a code owner

Assignees
No one assigned
Labels
TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugene123tw @harimkang @vinnamkim @jaegukhyun