Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine v1 perf benchmark to align with v2 #3006

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Refine v1 perf benchmark to align with v2 #3006

merged 6 commits into from
Feb 29, 2024

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Feb 29, 2024 •
edited
Loading

Summary

  • Align pytest / tox / GH workflow arguments with v2

How to test

  • CI tests

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81 goodsong81 added this to the 1.6.0 milestone Feb 29, 2024
@github-actions github-actions bot added TEST Any changes in tests BUILD labels Feb 29, 2024
@goodsong81 goodsong81 changed the title Refine v1 benchmark to align with v2 Refine v1 perf benchmark to align with v2 Feb 29, 2024
@goodsong81 goodsong81 force-pushed the test/refine-benchmark-v1 branch from d830274 to 231fec5 Compare February 29, 2024 07:01
@goodsong81 goodsong81 marked this pull request as ready for review February 29, 2024 07:17
@goodsong81 goodsong81 requested a review from a team as a code owner February 29, 2024 07:17
@goodsong81 goodsong81 merged commit db60f09 into develop Feb 29, 2024
4 of 7 checks passed
@goodsong81 goodsong81 deleted the test/refine-benchmark-v1 branch February 29, 2024 07:18
goodsong81 added a commit that referenced this pull request Feb 29, 2024
@goodsong81
Refine v1 perf benchmark to align with v2 (#3006)
9731048 
* Add --benchmark-type w/ accuracy|efficiency|all options

* Add perf-benchmark tox env

* Refine perf workflow to align with v2

* Add dummy perf tests for visual prompting

* Fix weekly workflow

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
goodsong81 added a commit that referenced this pull request Feb 29, 2024
@goodsong81
Refine v1 perf benchmark to align with v2 (#3006)
9575c88 
* Add --benchmark-type w/ accuracy|efficiency|all options

* Add perf-benchmark tox env

* Refine perf workflow to align with v2

* Add dummy perf tests for visual prompting

* Fix weekly workflow

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
goodsong81 added a commit that referenced this pull request Feb 29, 2024
@goodsong81
Refine v1 perf benchmark to align with v2 (#3006)
6489ea3 
* Add --benchmark-type w/ accuracy|efficiency|all options

* Add perf-benchmark tox env

* Refine perf workflow to align with v2

* Add dummy perf tests for visual prompting

* Fix weekly workflow

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
goodsong81 added a commit that referenced this pull request Feb 29, 2024
@goodsong81
Refine v1 perf benchmark to align with v2 (#3006)
cd17e23 
* Add --benchmark-type w/ accuracy|efficiency|all options

* Add perf-benchmark tox env

* Refine perf workflow to align with v2

* Add dummy perf tests for visual prompting

* Fix weekly workflow

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
sungchul2 added a commit that referenced this pull request Mar 8, 2024
@sungchul2 @goodsong81
Update visual prompting on 1.x (#3038)
d1a27ab 
* Refine v1 perf benchmark to align with v2 (#3006)

* Add --benchmark-type w/ accuracy|efficiency|all options

* Add perf-benchmark tox env

* Refine perf workflow to align with v2

* Add dummy perf tests for visual prompting

* Fix weekly workflow

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>

* Update docstring

* Update overlapped region refinement

* Update templates

* Remove `PromptGetter` during ov inference

* Fix tests

* For unittest coverage

---------

Co-authored-by: Songki Choi <songki.choi@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BUILD TEST Any changes in tests
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@goodsong81