Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes to omit artifact upload issue #2999

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Feb 27, 2024

Summary

After bump the actions/upload-artifact v4, uploading artifact multiple times with default name will raise error.
This PR is for fixing this issue by referring this migration guide

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@yunchu yunchu requested a review from a team as a code owner February 27, 2024 23:22
@github-actions github-actions bot added the BUILD label Feb 27, 2024
@yunchu yunchu changed the title apply changes to omit artifact upload issue Apply changes to omit artifact upload issue Feb 27, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (b0cbece) to head (33c3e05).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2999      +/-   ##
===========================================
- Coverage    81.15%   81.15%   -0.01%     
===========================================
  Files          520      520              
  Lines        39535    39535              
===========================================
- Hits         32086    32085       -1     
- Misses        7449     7450       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu merged commit 0ea5f8f into openvinotoolkit:develop Feb 28, 2024
17 of 18 checks passed
@yunchu yunchu deleted the fix-upload-artifacts-with-same-name-error branch February 28, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants