-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the accuracy and change meta_info -> label_info #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sungmanc
changed the title
Introduce the accuracy and change label_info -> meta_info
Introduce the accuracy and change meta_info -> label_info
Feb 27, 2024
sungmanc
requested review from
samet-akcay,
harimkang,
vinnamkim,
jaegukhyun,
eugene123tw,
kprokofi and
chuneuny-emily
as code owners
February 27, 2024 09:11
sungmanc
commented
Feb 27, 2024
harimkang
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! i left some comments and questions.
vinnamkim
reviewed
Feb 28, 2024
…nsions into introduce-cls-acc
vinnamkim
approved these changes
Feb 28, 2024
harimkang
approved these changes
Feb 28, 2024
jaegukhyun
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces,
CustomAccuracy
series, to make same results with the OTX1.x.meta_info
tolabel_info
. AlthoughDataModule
deliver themeta_info
to theLitModule
,meta_info
is only consumed at theHLabelClassification
. It should be applied to the all tasks._reset_prediction_layers
to theOVModel
andVPM Models
HLabelInfo
is generated to unify the order oflabel_groups
and hlabel information.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.