Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the accuracy and change meta_info -> label_info #2994

Merged
merged 14 commits into from
Feb 28, 2024

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Feb 27, 2024

Summary

This PR introduces,

  • Implement the CustomAccuracy series, to make same results with the OTX1.x.
  • Converted all meta_info to label_info. Although DataModule deliver the meta_info to the LitModule,
    meta_info is only consumed at the HLabelClassification. It should be applied to the all tasks.
    • Add the _reset_prediction_layers to the OVModel and VPM Models
  • Remove sort algorithm when HLabelInfo is generated to unify the order of label_groups and hlabel information.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungmanc sungmanc changed the title Introduce the accuracy and change label_info -> meta_info Introduce the accuracy and change meta_info -> label_info Feb 27, 2024
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! i left some comments and questions.

src/otx/core/data/module.py Show resolved Hide resolved
src/otx/core/metrics/accuracy.py Outdated Show resolved Hide resolved
src/otx/core/metrics/accuracy.py Outdated Show resolved Hide resolved
src/otx/core/model/module/classification.py Show resolved Hide resolved
src/otx/core/metrics/fmeasure.py Show resolved Hide resolved
src/otx/core/metrics/accuracy.py Outdated Show resolved Hide resolved
src/otx/core/data/dataset/segmentation.py Outdated Show resolved Hide resolved
@sungmanc sungmanc enabled auto-merge (squash) February 28, 2024 04:37
@sungmanc sungmanc merged commit f9aeb73 into openvinotoolkit:v2 Feb 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants