-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix label_to_idx
for hierarchical classification
#2906
Merged
GalyaZalesskaya
merged 7 commits into
releases/1.4.0
from
gz/release_14_fix_hcls_label_order
Feb 14, 2024
Merged
Fix label_to_idx
for hierarchical classification
#2906
GalyaZalesskaya
merged 7 commits into
releases/1.4.0
from
gz/release_14_fix_hcls_label_order
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API
Any changes in OTX API
ALGO
Any changes in OTX Algo Tasks implementation
labels
Feb 12, 2024
GalyaZalesskaya
force-pushed
the
gz/release_14_fix_hcls_label_order
branch
from
February 12, 2024 15:59
d2d3d57
to
6627401
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.4.0 #2906 +/- ##
==================================================
- Coverage 79.62% 79.61% -0.01%
==================================================
Files 506 506
Lines 38313 38317 +4
==================================================
+ Hits 30505 30507 +2
- Misses 7808 7810 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sovrasov
reviewed
Feb 12, 2024
src/otx/api/usecases/exportable_code/prediction_to_annotation_converter.py
Outdated
Show resolved
Hide resolved
GalyaZalesskaya
force-pushed
the
gz/release_14_fix_hcls_label_order
branch
from
February 12, 2024 23:31
26f31cf
to
c9dd261
Compare
sungmanc
reviewed
Feb 13, 2024
src/otx/api/usecases/exportable_code/prediction_to_annotation_converter.py
Outdated
Show resolved
Hide resolved
chuneuny-emily
previously approved these changes
Feb 14, 2024
sovrasov
approved these changes
Feb 14, 2024
@sovrasov @chuneuny-emily @sungmanc Can you please check if all suggestions are resolved? |
negvet
approved these changes
Feb 14, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue CVS-132079
Change
label_to_idx
to represent the model outputs order.For h-cls the labels order from model outputs and label_scema differ that caused fixes like PR#2440
The problem that after moving OpenVINO inference to Model API side, Model API required adding function to fix labels order for h-cls.
So I fixed
label_to_idx
dict to update label order without changes in Model API.Updated order for
labels
andlabel_ids
in .XML <model_info> meta to adjust to model outputs for Geti to pick saliency maps of the correct class index.Validation on Geti passed
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.