-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Anomalib v1 tasks to OTX v2 #2902
✨ Add Anomalib v1 tasks to OTX v2 #2902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I have a few comments.
I've pushed new changes. Not sure if this helps for now but maybe with the OTXModel refactor it might become better. But it would be nice to get feedback from you all. |
If possible, could you please separate IR-related functionality into the next PR? |
Do you want me to remove the export stuff from this PR? |
I'm not saying you have to do that, but if you think the IR is going to take a long time. It seems like a good idea to separate things that are going to take a long time. (It doesn't look good to have PRs open for too long.) If you do separate them, you can skip the IR-related integration tests for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashwinvaidya17, thanks a lot for the great effort! Much appreciated.
I've added some minor comments, and some questions.
Remove OpenVINO model Add anomalib install to tox Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
…nto feature/anomalibv1
Can we skip python 3.9 checks for anomaly task? Anomalib v1 supports 3.10 and above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort!
I talked to Mark and Emily about this, and we decided that OTX 2.0 will also not support python 3.9 for now. So I'm going to remove it from the CI test. |
i create PR (#2991) - Merged |
…nto feature/anomalibv1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add integration tests to CI in the next PR? I think we need to add tasks to tox.ini
and .github/workflows/pre_merge.yaml
.
Summary
Remaining
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.