-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update visual prompting task (finetuning & zero-shot learning) #2892
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2892 +/- ##
===========================================
+ Coverage 81.06% 81.16% +0.09%
===========================================
Files 520 520
Lines 39361 39535 +174
===========================================
+ Hits 31909 32088 +179
+ Misses 7452 7447 -5 ☔ View full report in Codecov by Sentry. |
...thms/visual_prompting/adapters/pytorch_lightning/models/visual_prompters/segment_anything.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks good to me, but I left few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d030427
Summary
This PR includes:
learn
andinfer
for standalone module usecaseinfer
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.