-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XAI hook for Mask-RCNN #2870
Merged
sovrasov
merged 20 commits into
openvinotoolkit:v2
from
GalyaZalesskaya:gz/v2-xai-maskrcnn
Feb 5, 2024
Merged
Add XAI hook for Mask-RCNN #2870
sovrasov
merged 20 commits into
openvinotoolkit:v2
from
GalyaZalesskaya:gz/v2-xai-maskrcnn
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalyaZalesskaya
requested review from
samet-akcay,
harimkang,
vinnamkim,
jaegukhyun,
sungmanc,
eugene123tw,
kprokofi and
chuneuny-emily
as code owners
February 2, 2024 00:28
vinnamkim
reviewed
Feb 2, 2024
vinnamkim
reviewed
Feb 2, 2024
negvet
reviewed
Feb 2, 2024
negvet
reviewed
Feb 2, 2024
negvet
reviewed
Feb 2, 2024
negvet
reviewed
Feb 2, 2024
You will add tests when mask-rcnn predictions will be fixed? |
I wanted to add unit tests with simple shape checks in a separate PR , but I can do it now, it's even better |
negvet
approved these changes
Feb 2, 2024
vinnamkim
approved these changes
Feb 5, 2024
sovrasov
approved these changes
Feb 5, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added algorithm for Mask RCNN saliency generation using predicted
masks
in model's outputs.Added dummy
MaskRCNNRecordingForwardHook
to save logic with hooks for all XAI algorithms, but the main saliency map generation is happening inMaskRCNNRecordingForwardHook.get_sal_map_from_preds
class methodTODO for future PRs:
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.