Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XAI hook for Mask-RCNN #2870

Merged
merged 20 commits into from
Feb 5, 2024

Conversation

GalyaZalesskaya
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya commented Feb 2, 2024

Summary

Added algorithm for Mask RCNN saliency generation using predicted masks in model's outputs.

Added dummy MaskRCNNRecordingForwardHook to save logic with hooks for all XAI algorithms, but the main saliency map generation is happening in MaskRCNNRecordingForwardHook.get_sal_map_from_preds class method

TODO for future PRs:

  • Current masks from Mask RCNN are wrong and the reason needs to be investigated

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@GalyaZalesskaya GalyaZalesskaya marked this pull request as ready for review February 2, 2024 00:28
@GalyaZalesskaya GalyaZalesskaya added the ALGO Any changes in OTX Algo Tasks implementation label Feb 2, 2024
src/otx/engine/engine.py Outdated Show resolved Hide resolved
@negvet
Copy link
Collaborator

negvet commented Feb 2, 2024

You will add tests when mask-rcnn predictions will be fixed?

@GalyaZalesskaya
Copy link
Contributor Author

You will add tests when mask-rcnn predictions will be fixed?

I wanted to add unit tests with simple shape checks in a separate PR , but I can do it now, it's even better

@github-actions github-actions bot added the TEST Any changes in tests label Feb 2, 2024
@sovrasov sovrasov merged commit 80c8b34 into openvinotoolkit:v2 Feb 5, 2024
8 checks passed
@vinnamkim vinnamkim mentioned this pull request Feb 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants