Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XAI detection hook #2842

Merged

Conversation

GalyaZalesskaya
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya commented Jan 26, 2024

Summary

  • Added DetClassProbabilityMapHook for detection models: ATSS, SSD, YOLOX
  • Added tests for hook
  • Small updates in setup_guide.md

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests DOC Improvements or additions to documentation labels Jan 26, 2024
@GalyaZalesskaya GalyaZalesskaya added the ALGO Any changes in OTX Algo Tasks implementation label Jan 26, 2024
@GalyaZalesskaya
Copy link
Contributor Author

After merging v2 code-quility checks are failing

vinnamkim
vinnamkim previously approved these changes Jan 29, 2024
@negvet
Copy link
Collaborator

negvet commented Jan 29, 2024

I believe with this PR we can extend the scope for

def test_otx_explain_e2e(recipe: str, tmp_path: Path, fxt_accelerator: str) -> None:
"""
Test OTX CLI explain e2e command.
Args:
recipe (str): The recipe to use for training. (eg. 'classification/otx_mobilenet_v3_large.yaml')
tmp_path (Path): The temporary path for storing the training outputs.
Returns:
None
"""
task = recipe.split("/")[-2]
model_name = recipe.split("/")[-1].split(".")[0]
if "_cls" not in task:
pytest.skip("Supported only for classification tast.")
if "deit" in model_name or "dino" in model_name:
pytest.skip("Supported only for CNN models.")

What do you think?

@negvet
Copy link
Collaborator

negvet commented Jan 29, 2024

Also please manually check if it works for some random model, if not yet

@GalyaZalesskaya
Copy link
Contributor Author

I believe with this PR we can extend the scope for integration/test_cli.py

Thank you for the comment, I extended scope of e2e tests, here is the list of the tests
image

Copy link
Collaborator

@negvet negvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@MarkByun MarkByun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GalyaZalesskaya GalyaZalesskaya merged commit 752b987 into openvinotoolkit:v2 Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants