-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-work for the design change: create own python class for every model #2775
Pre-work for the design change: create own python class for every model #2775
Conversation
b708ad1
to
bc6e7fc
Compare
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, BTW, could you please explain why do we need to insert the num_classes
to the OTXModel
at this PR ? I'm not opposite to inject this argument, however, just curiosity. It seems that inserting the num_classes
have no much relation with own python class.
We introduce |
Summary
OTXModel
to haveexport()
,register_explain_hook()
, andlabel_info
property.label_info
will be automatically constructed by the input integer argument,num_classes
.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.