Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch mmaction2 at installation #2756

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Patch mmaction2 at installation #2756

merged 3 commits into from
Jan 4, 2024

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 3, 2024 •
edited
Loading

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM BUILD OTX 2.0 labels Jan 3, 2024
@vinnamkim vinnamkim marked this pull request as ready for review January 3, 2024 07:06
@vinnamkim
Patch mmaction2 at installation
212b7e0 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim mentioned this pull request Jan 3, 2024
Closed
8 tasks
jaegukhyun
jaegukhyun previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, How about adding some explanations why do we need this kind of patch.
Docstring of patch_mmaction2 function or docstring of src/otx/cli/patches/mmaction2.patch file would be nice

@vinnamkim
Copy link
Contributor Author

LGTM, How about adding some explanations why do we need this kind of patch. Docstring of patch_mmaction2 function or docstring of src/otx/cli/patches/mmaction2.patch file would be nice

What's the main reason that we need to patch mmaction2? I don't know exactly.

@jaegukhyun
Copy link
Contributor

LGTM, How about adding some explanations why do we need this kind of patch. Docstring of patch_mmaction2 function or docstring of src/otx/cli/patches/mmaction2.patch file would be nice

What's the main reason that we need to patch mmaction2? I don't know exactly.

init.py is missing in https://github.com/open-mmlab/mmaction2/tree/v1.2.0/mmaction/models/localizers/drn

@vinnamkim
Change from importlib.resources to importlib_resources
a6194de 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add importlib_resources to direct dependencies
64e961d 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Copy link
Contributor Author

LGTM, How about adding some explanations why do we need this kind of patch. Docstring of patch_mmaction2 function or docstring of src/otx/cli/patches/mmaction2.patch file would be nice

What's the main reason that we need to patch mmaction2? I don't know exactly.

init.py is missing in https://github.com/open-mmlab/mmaction2/tree/v1.2.0/mmaction/models/localizers/drn

Fixed in 64e961d

@vinnamkim vinnamkim merged commit 1bf65fa into openvinotoolkit:v2 Jan 4, 2024
6 checks passed
@vinnamkim vinnamkim deleted the patch-mmaction2-in-otx-install branch January 4, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@wonjuleee wonjuleee wonjuleee approved these changes

@sungmanc sungmanc sungmanc approved these changes

@harimkang harimkang harimkang approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@eugene123tw eugene123tw Awaiting requested review from eugene123tw eugene123tw is a code owner

@kprokofi kprokofi Awaiting requested review from kprokofi kprokofi is a code owner

Assignees
No one assigned
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinnamkim @jaegukhyun @harimkang @sungmanc @wonjuleee