-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance classification task's model performance #2749
Merged
vinnamkim
merged 8 commits into
openvinotoolkit:v2
from
vinnamkim:enhance/perf-classification
Jan 3, 2024
Merged
Enhance classification task's model performance #2749
vinnamkim
merged 8 commits into
openvinotoolkit:v2
from
vinnamkim:enhance/perf-classification
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Correctly shutdown Memcaching instance for consecutive train function calls Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
vinnamkim
requested review from
samet-akcay,
harimkang,
jaegukhyun,
sungmanc,
eugene123tw and
kprokofi
as code owners
December 26, 2023 07:24
harimkang
previously approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sungmanc
previously approved these changes
Dec 26, 2023
|
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
jaegukhyun
reviewed
Jan 3, 2024
jaegukhyun
reviewed
Jan 3, 2024
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
jaegukhyun
approved these changes
Jan 3, 2024
sungmanc
approved these changes
Jan 3, 2024
harimkang
approved these changes
Jan 3, 2024
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Memory caching
multiprocessing.Manager
can be shutdown not in the main thread (dataloader's worker thread).Change image decoder from OpenCV to PIL
Set
pin_memory=True
inDataLoader
.Utilize a stacked tensor for a batch of images rather than a list of individual images.
How to test
I updated our unit tests related to this change and the integration tests must guard the correct training pipeline.
Checklist
License
Feel free to contact the maintainers if that's a concern.